Ensure that the length property won't be *accidentally* accessed on a DecodeStream-instance
#12365
Conversation
… a `DecodeStream`-instance For these streams, compared to `Stream` and `ChunkedStream`, there's no well defined concept of length and consequently no `length` getter.[1] However, attempting to access the non-existent `length` won't currently error, but just return `undefined`, which could thus easily lead to bugs elsewhere in the code-base. --- [1] However, note that *all* stream implementations have an `isEmpty` getter which can be used instead.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/aa801bcb51e8a73/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/96b7ba68ba0be29/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/aa801bcb51e8a73/output.txt Total script time: 27.53 mins
Image differences available at: http://54.67.70.0:8877/aa801bcb51e8a73/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/96b7ba68ba0be29/output.txt Total script time: 29.46 mins
Image differences available at: http://54.215.176.217:8877/96b7ba68ba0be29/reftest-analyzer.html#web=eq.log |
|
Thank you for fixing this potential problem! (I recall this was a point of attention during the AcroForm/XFA work.) |
For these streams, compared to
StreamandChunkedStream, there's no well defined concept of length and consequently nolengthgetter.[1] However, attempting to access the non-existentlengthwon't currently error, but just returnundefined, which could thus easily lead to bugs elsewhere in the code-base.[1] However, note that all stream implementations have an
isEmptygetter which can be used instead.